Template talk:Legends Card Summary

Parameters for Card effects

I like to make a case to include all card effects from Card Effects onto this page. I also like to discuss the possibility to add params to associated cards.
First things first, there are four different categories of card effects. 1: Keywords, these are inherent abilities linked to the card that alter game rules. 2: Triggered abilities, these are abilities with the following design "(name): When (trigger), then (effect)". Pilfer and Last Gasp are two examples. 3: Effect abilities, these are abilities that have the effect incorporated in itself. Heal and Move are nice examples. 4: Status effects, like Wounded or Cover that give a continuous status to cards.
The difference between 2 and 3 is nicely shown on Beast Form. Beast Form itself is an ability from category 2, but the effect that Changes the creature falls in category 3. At this moment, only category 1 and 2 are used as params in this template, because they are 'attached' to the card itself and not just a one time effect. This is quite convenient, because we can use #listsaved to display and automatically update tables that include cards with these effects. However, we use a lot of tables that also need to include cards with category 3 and 4 effects. So many, that it almost impossible to keep them manually up to date with the new expansions. This is also the problem with the associated cards for all four categories (see Legends:Breakthrough#Cards associated with Breakthrough or Legends:Shackle#Cards associated with Shackle.
Thus I like to propose that cards that can give Shackle/Heal/Move/etc. will get their respective param shackle/heal/move=1. Secondly, cards that are associated with (for example) Breakthrough or Shackle will get the param breakthrough/shackle=2 if that is even possible. --Ilaro (talk) 16:14, 13 November 2017 (UTC)

The one place this might get tricky is if, for example, a card needs to have both shackle=1 and shackle=2 at the same time. If there are any cases like that, this plan would fail, but we could do something like shackle=1 for regular cards, and shacklea=1 (or whatever name makes sense) for cards that are associated with the effect. – Robin Hood  ^(talk) 00:05, 15 November 2017 (UTC)

I didn't think about that, but it sounds reasonable! --Ilaro (talk) 08:10, 15 November 2017 (UTC)

I've added the new parameters to the template. For now, they do nothing except get saved, meaning they can be used with listsaved. I wasn't sure if we wanted categories for them as well. Also, I went with adding the 'a' in front, as I thought it was easier to read that way (though it does funny things with "ward", which becomes "award"). I'll get the bot to update the cards based on the existing Card Data templates, and then we can manually change them over to listsaved once it's done. It'd take longer to program the bot to do that than for us to just do it, I think. Once that's done, I'll write another job to update the actual counts in the keyword headers. – Robin Hood  ^(talk) 08:01, 21 November 2017 (UTC)

Okay, so, in testing, I came up against Cards opposed to Guard. What do we do with those, if anything? – Robin Hood  ^(talk) 09:18, 21 November 2017 (UTC)

I updated the listsaved with all card effects now (and associated), I hope that will not interfere with your bot! I am not sure if cats are that important for the moment, we can always decide later if we want them. I have been thinking about the 'oppose to Guard' (completely forgot about it when I asked this question in the first place), but maybe they should just be added to the associated list. --Ilaro (talk) 13:20, 21 November 2017 (UTC)

That would certainly make my life easier, but that's not a really good reason to decide to do it that way. :) For now, though, I'll do it that way. If Guard is the only one like that, then changing the few cards affected isn't a big deal to do by hand later if we change our minds. Thanks for updating the list—I'd meant to ask if it was complete, and I just forgot. It's not hard to add the new ones to the bot...just takes a few seconds, so not a big deal on that front. – Robin Hood  ^(talk) 20:00, 21 November 2017 (UTC)

Besides Guard, only Cover has a couple of 'oppose' cards, but I did just add them to the associated table, because there were so few of them. It might still be good idea to split them though. Adding cats for each of them shouldn't be a big problem, right? Just copy/paste a line like this {{#if:{{{pilfer|}}}|[[Category:Legends-Cards-{{{type|}}} with Pilfer Abilities]]}} and change it to the desired effect? If that is easily done by bot, then go for it, otherwise I will probably add them manually in the next couple of days. --Ilaro (talk) 20:12, 21 November 2017 (UTC)

The bot normally stays out of template space because of the complexity. Far safer (and probably easier) for a human to do it. Oh, and yes, that's what you'd want to do to add cats to them. – Robin Hood  ^(talk) 01:18, 23 November 2017 (UTC)

(←) The bot's finished its run now. As discussed, it will have lumped the "opposed to" together with the "associated with" cards. That's easy enough to separate out by hand for only two pages if we change our minds. The #listsaved's will also need to be converted by hand, but now that the bot's done, they should populate automatically with everything they had previously. – Robin Hood  ^(talk) 02:18, 23 November 2017 (UTC)

Type

Hi there! There is a problem with parameter "type" right. If card have only one type, some code part appears on the page. And cards mostly have only one type. Example: Legends:Elixir of Vigor. I know you know this, just for reminder. Hedera helix (talk) 10:52, 30 November 2017 (UTC) Added: Wow, it's not only type. Look on categories on example. The template need to be fixed ASAP.

I reverted everything. Can take a couple of minutes before all the pages are fixed again until the queue is empty. One of our users tried something new, which didn't work out as he expected. Next time use the sandbox Fullerton :) --Ilaro (talk) 11:07, 30 November 2017 (UTC)

Are those changes needed? The code had the right idea, just a couple of mistakes in it. It would be easy to put them back in place, but I don't want to do so if they're not actually needed. – Robin Hood  ^(talk) 17:01, 30 November 2017 (UTC)

Some cards now have two subtypes. This led me to believe that something of the sort is needed. —Fullerton ﴾talk﴿ 17:16, 30 November 2017 (UTC)

{{LABELNAME}}

Due to the use of {{LABELNAME}} cards with parenthesis in their name are not linked accordingly to their page when used inside tables. Three examples below:

Deck List

	Name	Type (Subtype)					Ability
	Aela the Huntress	Creature (Nord)	7	3	3	4 Legendary	Summon: Deal 1 damage. Beast Form: +2/+2 and destroy a Wounded creature.
	Aela the Huntress	Creature (Werewolf)	7	5	5	4 Legendary
	Skeleton	Creature (Skeleton)	1	1	1	1 Common

However, if I would change it to {{CORENAME}}, everything inside parenthesis will be visible. I don't think this is a problem with the werewolf cards, but it shouldn't be visible for Legends:Skeleton (card) or Legends:Chaurus. --Ilaro (talk) 18:31, 1 December 2017 (UTC)

The problem, as you've already noted indirectly, is that sometimes the <legendscard> name matches the page name and sometimes it doesn't. I've added an lcname parameter, which should work around the problem. I believe only those page names ending in "(card)" will need to be updated, which I'll do right now, since I have a handy list of all of them. If you spot any other problems, let me know. – Robin Hood  ^(talk) 19:43, 1 December 2017 (UTC)

It seems that some of cards with disambigs are not working properly, which I believe is due to this change. Probably all those cards that got a disambig after the change are affected. Could you show me how you fixed the others so when I add more to the disambig roster I can just repeat your actions? --Ilaro (talk) 01:24, 25 March 2018 (UTC)

Just add |lcname=whatever to the Legends Card call and specify the correct name. I think that should fix it. In the Decklist itself, you would still continue to use the full page name. – Robin Hood  ^(talk) 06:29, 25 March 2018 (UTC)

Pluralise Categories

All sub-categories in Category:Legends-Cards-Item need to be corrected to the plural, eg "Legends-Cards-Items with xx". The template will need to be modified to populate the correct naming. Similarly all "with" categories in Creature need to be fixed and separated from just creatures. All Action and Support "with" cards would benefit from the addition of the word "cards", eg "Action Cards with Invade", while the Support cards need their categories at least homogenised. Silence is Golden^{Break the Silence} 01:48, 24 October 2019 (GMT)

Agreed. While a simple change, it's a bit of a hassle because there are quite a lot of categories after all this time. The template is easy to change and the categories are then automatically fixed on the affected pages. However, the category pages themselves also need to be moved/renamed after that. I'll have a look if it's feasible to do manually or that it's easier with a bot run. --Ilaro (talk) 12:45, 24 October 2019 (GMT)